-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide raw counters metrics (#5735) #5802
Conversation
category = CATEGORY_METRICS, | ||
doc = "If true, export raw counter topic level metrics" | ||
) | ||
private boolean exposeCounterTopicMetricsInPrometheus = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this flag.
if exposeTopicLevelMetricsInPrometheus
is true, we can expose this counter. there should be no penalty to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with your point of view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, doing the modifications
run java8 tests |
run cpp tests |
Thanks! |
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. New unit test added.
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 ### Motivation Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. ### Verifying this change New unit test added.
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. New unit test added. (cherry picked from commit 204f327)
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 ### Motivation Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. ### Verifying this change New unit test added.
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #5735
Motivation
Add counter based metrics for topics.
Modifications
Added counter on AbstractTopics and propagate the result to the PrometheusHandler.
Verifying this change
Added a test
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation